fix(utils): isInRange, range 로직 개선 및 한글화 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e89cac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Sangminnn isInRange의 옵션으로 EqualOptions 객체를 제거합니다. 중첩 객체가 사용성을 많이 떨어뜨리는 것 같습니다. 🥲 |
ssi02014
commented
Oct 31, 2024
Comment on lines
-48
to
-49
| if (isNil(min) || isNil(max)) { | ||
| throw new Error('min and max values are invalid.'); |
There was a problem hiding this comment.
타입스크립트로 작성되어 min, max 값을 검증하는 것은 불필요해 보여 제거합니다!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 97.41% 97.05% -0.36%
==========================================
Files 164 173 +9
Lines 1470 1563 +93
Branches 361 392 +31
==========================================
+ Hits 1432 1517 +85
- Misses 34 41 +7
- Partials 4 5 +1
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix(utils): isInRange, range 로직 개선 및 한글화
PR Checklist
Contributing Guide