Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): formatSizeStyleValue 함수 추가 #521

Merged

Conversation

99mini
Copy link
Contributor

@99mini 99mini commented Oct 21, 2024

Overview

Issue: #345

number값을 suffix를 붙여 css 스타일 값으로 사용할 수 있게 반환합니다.

suffix는 옵션널하고 디폴트로 px를 사용합니다.

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

@99mini 99mini requested a review from ssi02014 as a code owner October 21, 2024 01:23
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: ba60682

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modern-kit/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (33cf068) to head (ba60682).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   97.41%   97.60%   +0.19%     
==========================================
  Files         164      174      +10     
  Lines        1470     1545      +75     
  Branches      361      388      +27     
==========================================
+ Hits         1432     1508      +76     
+ Misses         34       33       -1     
  Partials        4        4              
Components Coverage Δ
@modern-kit/react 95.58% <92.30%> (+0.37%) ⬆️
@modern-kit/utils 100.00% <100.00%> (ø)

@ssi02014 ssi02014 added feature 새로운 기능 추가 @modern-kit/utils @modern-kit/utils labels Oct 21, 2024
Copy link
Contributor

@ssi02014 ssi02014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업 감사합니다 :)

@ssi02014 ssi02014 linked an issue Oct 21, 2024 that may be closed by this pull request
2 tasks
@ssi02014 ssi02014 merged commit a291208 into modern-agile-team:main Oct 21, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 추가 @modern-kit/utils @modern-kit/utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: formatSizeStyleValue
2 participants