Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): useBlockPromiseMultipleClick #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sangminnn
Copy link
Collaborator

@Sangminnn Sangminnn commented Sep 25, 2024

해당 훅 사용 시 Error 상황에서 isLoading값이 변경되지 않는 이슈가 있어 코드를 수정했습니다.

그 과정에서 기존에 blockMultipleClick 함수가 훅 내부에서 state의 변경에도 불필요하게 재생성되지 않도록 memoization을 적용했습니다.

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 6b92bce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Sangminnn Sangminnn self-assigned this Sep 25, 2024
@Sangminnn Sangminnn added @modern-kit/react @modern-kit/react fix 버그 수정 및 코드 개선 labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (33cf068) to head (6b92bce).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   97.41%   97.54%   +0.13%     
==========================================
  Files         164      166       +2     
  Lines        1470     1469       -1     
  Branches      361      363       +2     
==========================================
+ Hits         1432     1433       +1     
+ Misses         34       32       -2     
  Partials        4        4              
Components Coverage Δ
@modern-kit/react 95.46% <89.24%> (+0.24%) ⬆️
@modern-kit/utils 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 및 코드 개선 @modern-kit/react @modern-kit/react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant