Add shadow memory instrumentation to ArrayVec #3243
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds shadow memory instrumentation inside the
ArrayVecdata structure (from thearrayveccrate) that check that accessed memory locations are properly initialized.All instrumentation is marked by a comment of the following form:
and are only done in
arrayvec.rsandarrayvec_impl.rs, so these are the only two files that need to be reviewed.The PR includes one harness that checks that simple push/pop operations are safe with respect to accessing initialized memory.
Keeping this as a draft till we add modified copyright notices and a few more harnesses.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.