WebDriver: Retry fetching content description #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekpacia
reviewed
Aug 23, 2024
| if (contentDesc == null) { | ||
| retry++ | ||
| } | ||
| if (retry == 10) { |
There was a problem hiding this comment.
- Let's extract
10to some constant. - Let's add issue link to the comment for context. E.g.
See issue #1936
|
Thank you. I updated the PR. |
|
Thanks, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a workaround for the
WebDriverproblem described in #1936. We are filling a login form and press the login button. During that navigation there's a short time where the content description isnullwhich results in a forced crash.With this workaround we try again to fetch the content description for a limited time until we finally give up.
Testing
Tested locally with Chrome
128.0.6613.85.Issues fixed
Closes #1936.