Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/maestro ai #1906
Feature/maestro ai #1906
Changes from all commits
a7b5969
3916aff
e58ceb9
0d7f025
8237e63
2b29c53
d089f0c
fc57417
d23a25f
0f7b418
b76d5e1
c7e3c8f
33f0c84
1c0072b
18345a3
f2e9db6
b928f67
19a60c4
0dca65e
85f46c6
b264371
a49ed5a
c73aedf
e88635b
dde135a
cbad634
c50192f
9ae8a6d
92466ff
9726ea8
6ccf1b0
8a5a418
14ffa2a
87a46f7
0fb5550
c706d48
8ecdd8b
d9e060e
6f041c9
c0b69c5
ba69273
ba04550
2ef50d5
df6a274
78c04a3
674a717
c2e8623
f848f31
b8e08d7
0bfac77
a927e05
8668cad
507afea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be the expected output? would be helpful to document that as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added expected output.
Also, I think we should add a link where the fixtures can be downloaded from. Otherwise the barrier entry to this DemoApp is very high, because of the need to take the screenshots manually.
Currently the fixtures dataset I use is from https://github.com/mobile-dev-inc/copilot/pull/188.
I will upload that dataset to GCP and paste the link here. Do you see any problem with it? I think the customer apps that are in https://github.com/mobile-dev-inc/copilot/pull/188 are okay with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not public the GCS link for now, you can make it work for any storage link. Lets write a runbook internally for this in case some one from us wants to evaluate. This repository should ideally have access to general data (from open source apps) instead of customer apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, though I don't agree.
I'd prefer to have this dataset public, internal runbooks tend to rot and no one uses them unless really needed. But if we made this testing dataset public, anybody could play around with LLM outptus and submit a PR that improves it.
If this requires removing apps from our customers, and using screenshots from more popular, well known apps instead (like Uber, Bolt), then I still think it's worth the effort. We should strive to make working on Maestro possible and easy to people outside of @mobile-dev-inc.
PS 1 The perfect situation would be that generating screenshots for each app with
takeScreenshot
. But I think it's too much work to automate this, and what we have now is enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said: I will take no action for now.