Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom labels for readability and CLI output #1481

Merged
merged 21 commits into from
Nov 21, 2023
Merged

Conversation

amanjeetsingh150
Copy link
Collaborator

Proposed Changes

Builds on the work of @SuperRoach in #1238

Adds a label attribute to a number of commands. This:

  • adds readability to the file as to the purpose of a particular step (especially relevant for tapping on points or vague element selectors)
  • is also returned in the description() method of those commands to be displayed in the CLI output.

I'm a first-timer, so have some outstanding questions:

  • Does this need a Docs PR ready for merge before this can be merged?
  • Is there additional testing that could/should be done?
  • Is partial support for label acceptable, so long as it's documented?

Testing

  • Extended Unit tests
  • Added new Integration test
  • Tested locally by amending my own flows (the reason I'm working on this 😉)

Issues Fixed

Solves #1229 and provides a workaround for #1226

@szobov
Copy link

szobov commented Oct 23, 2023

Hey @amanjeetsingh150
Thanks a lot for bringing it!
I want to ask, what can I help you with to have this PR merged?
I'm very much looking forward to this feature.

@amanjeetsingh150
Copy link
Collaborator Author

Hey @szobov I am going to rebase this soon and start testing to check if this not creates a regression

Copy link

Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change

@szobov
Copy link

szobov commented Nov 16, 2023

Hey @amanjeetsingh150
Thanks a lot for the job you've done!
Is it time to merge it?

Btw, we plan to use this feature as soon as it is released, so we can provide feedback as early adopters. :)

@amanjeetsingh150 amanjeetsingh150 merged commit 0f6db93 into main Nov 21, 2023
2 checks passed
@amanjeetsingh150 amanjeetsingh150 deleted the FEAT-custom-labels branch November 21, 2023 01:45
@amanjeetsingh150
Copy link
Collaborator Author

Hey @szobov thanks for checking in! Apologies I was out for this week and couldn't follow up. This should be getting in for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants