-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom labels for readability and CLI output #1481
Conversation
Hey @amanjeetsingh150 |
Hey @szobov I am going to rebase this soon and start testing to check if this not creates a regression |
0f056d1
to
95c32c1
Compare
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
a608f02
to
0ce279c
Compare
Hey @amanjeetsingh150 Btw, we plan to use this feature as soon as it is released, so we can provide feedback as early adopters. :) |
…or this text to appear in your log/command display.
Co-authored-by: Igor Lema <[email protected]>
Co-authored-by: Igor Lema <[email protected]>
- for YamlInputText, YamlAssertTrue, YamlEvalScript
0ce279c
to
0c6c650
Compare
Hey @szobov thanks for checking in! Apologies I was out for this week and couldn't follow up. This should be getting in for the next release. |
Proposed Changes
Builds on the work of @SuperRoach in #1238
Adds a
label
attribute to a number of commands. This:description()
method of those commands to be displayed in the CLI output.I'm a first-timer, so have some outstanding questions:
label
acceptable, so long as it's documented?Testing
Issues Fixed
Solves #1229 and provides a workaround for #1226