v1.16.0 (#916)

* Update go-button.component.scss Changes for split button option text not to wrap and grow towards left. * GOP-877-BUG-minimum_height_for_textarea Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix. * Changes_bugfix_chore_task * alignment corrected for icon button css changes for button padding * codeclimate issue fix * Codeclimate fix * remove extra padding * Initial components and module interaction * Accordion_style changes Accordion styles Default Slim Dark * Changed dark theme * Changes [CHORE] 868 max height for toast Max height for the toast notification will not have an overflow unless specified. * Changes [CHORE] 767 action sheet design changes #767 1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet. * Update _forms.scss * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * Determinate and indeterminate progress bar * style update * Changes [CHORE] 868 max height for toast #890 1. Code review suggested changes. 2. Change in the code's header part in the documentation. * UT * safari styling fix * Fixing code climate issues * Changes [CHORE] 868 max height for toast #890 Code review suggested changes. * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * comment line message * clear code climate issues * code climate fix * dark theme color changes done * issue fixed * removed white spaces * BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE * ALIGNMENT AND NAMING CHANGES * Fix for duplicate modal and offcanvas content * ALIGNMENT_CHANGES * removing whitespace * Re-run Checks * Re-run Checks * Increasing test coverage * Update github src * GOP-807 empty checkin to trigger build * Fix select all filtered list (#914) * bug fixes for select all filtered list * single item, add remove handled * handling controls initial value incase of typeahead provided * changes in handling controls initial value * small condition fix * test cases updated and condition change in init control value * formatting changes * formatting changes * edge case handled while removing selected item * formatting changes * adding count to select all * adding count to select all * linting errors fixed * typo fixed * refactored code for better understanding * refactoring * lint fix * indentation changes, private methods and variables grouped, minor ux changes * renaming methods * karma config thresold changes --------- Co-authored-by: Vishal Shah <[email protected]> * v1.16.0 (#915) * Incrementing minor version Changes were made to upgrade "select all filter list" * Fixing patch version to be 0 Forgot to do this before... --------- Co-authored-by: sudheepdivakargithub <[email protected]> Co-authored-by: adhiyan-tangoe <[email protected]> Co-authored-by: Saravanan Muralidharan <[email protected]> Co-authored-by: Pooja-kj <[email protected]> Co-authored-by: Vijeta7 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: RonMichaud <[email protected]> Co-authored-by: Vishal Shah <[email protected]>
mobi · Jun 9, 2023 · 669fcf9 · 669fcf9
1 parent e2cff69
commit 669fcf9
Show file tree

Hide file tree

Showing 44 changed files with 842 additions and 77 deletions.
diff --git a/projects/go-lib/karma.conf.js b/projects/go-lib/karma.conf.js
@@ -22,7 +22,7 @@ module.exports = function (config) {
       thresholds: {
         statements: 93,
         lines: 92,
-        branches: 79,
+        branches: 75,
         functions: 88,
       },
     },

diff --git a/projects/go-lib/package.json b/projects/go-lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tangoe/goponents",
-  "version": "1.15.1",
+  "version": "1.16.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/mobi/goponents.git"

diff --git a/projects/go-lib/src/lib/components/go-accordion/go-accordion-panel.component.scss b/projects/go-lib/src/lib/components/go-accordion/go-accordion-panel.component.scss
@@ -67,7 +67,7 @@
 
     cursor: pointer;
     display: flex;
-    font-size: 1.2rem;
+    font-size: 1.125rem;
     padding: 1.2rem 1rem;
     position: relative;
 
@@ -76,10 +76,10 @@
     }
 
     &--dark {
-      background-color: darken($base-dark-secondary, 7%);
+      background-color: $base-dark;
 
       &:hover {
-        background-color: darken($base-dark-secondary, 3.5%);
+        background-color: darken($base-dark, 3.5%);
       }
     }
 
@@ -88,13 +88,17 @@
 
       // scss-lint:disable SelectorFormat
       &.go-accordion-panel__header--dark {
+        background-color: darken($base-dark-secondary, 3.5%);
+      }
+
+      &.go-accordion-panel__header--dark:hover {
         background-color: darken($base-dark-secondary, 7%);
       }
     }
 
     &--slim {
-      font-size: 1rem;
-      padding: 1rem;
+      font-size: 0.875rem;
+      padding: 0.625rem 1rem;
     }
   }
 
@@ -132,9 +136,11 @@
   }
 
   &__content {
-    padding: 1.5rem 1rem;
+    font-size: 0.875rem;
+    padding: 1rem;
 
     &--slim {
+      font-size: 0.875rem;
       padding: 1rem;
     }
 

diff --git a/projects/go-lib/src/lib/components/go-action-sheet/go-action-sheet.component.scss b/projects/go-lib/src/lib/components/go-action-sheet/go-action-sheet.component.scss
@@ -10,13 +10,13 @@ $as-before-box-diag-width: 21.21px;
   position: relative;
 
   &__scroll-container {
-    max-height: 375px;
-    overflow: auto;
+    overflow: hidden;
   }
 
   &__content {
     border-radius: $global-radius;
-    overflow: hidden;
+    max-height: 375px;
+    overflow: auto;
   }
 
   &__content-container {

diff --git a/projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss b/projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
@@ -61,12 +61,8 @@ $theme-light-transparentized: rgba($theme-light-color, .5);
       color: $ui-color-negative;
     }
 
-    .go-panel {
-      &__title {
-        & &-text {
-          color: $ui-color-negative;
-        }
-      }
+    .go-panel__title-text {
+      color: $ui-color-negative;
     }
   }
 

diff --git a/projects/go-lib/src/lib/components/go-badge/go-badge.component.spec.ts b/projects/go-lib/src/lib/components/go-badge/go-badge.component.spec.ts
@@ -22,4 +22,42 @@ describe('GoBadgeComponent', () => {
   it('should create', () => {
     expect(component).toBeTruthy();
   });
+
+  describe("badgeClasses()", () => {
+    beforeEach(() => {
+      component.badgeStyles = {};
+    });
+
+    it("returns an object that sets go-badge--positive to true based on type", () => {
+      expect(component.badgeStyles["go-badge--positive"]).toBeFalsy();
+
+      component.badgeColor = "positive";
+      component.ngOnChanges();
+      expect(component.badgeStyles["go-badge--positive"]).toBe(true);
+    });
+
+    it("returns an object that set go-badge--negative to true based on type", () => {
+      expect(component.badgeStyles["go-badge--negative"]).toBeFalsy();
+
+      component.badgeColor = "negative";
+      component.ngOnChanges();
+      expect(component.badgeStyles["go-badge--negative"]).toBe(true);
+    });
+
+    it("returns an object that set go-badge--neutral to true based on type", () => {
+      expect(component.badgeStyles["go-badge--neutral"]).toBeFalsy();
+
+      component.badgeColor = "neutral";
+      component.ngOnChanges();
+      expect(component.badgeStyles["go-badge--neutral"]).toBe(true);
+    });
+
+    it("returns an object that set go-badge--dot to true based on type", () => {
+      expect(component.badgeStyles["go-badge--dot"]).toBeFalsy();
+
+      component.displayData = false;
+      component.ngOnChanges();
+      expect(component.badgeStyles["go-badge--dot"]).toBe(true);
+    });
+  });
 });
diff --git a/projects/go-lib/src/lib/components/go-button/go-button.component.scss b/projects/go-lib/src/lib/components/go-button/go-button.component.scss
@@ -54,7 +54,7 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
   }
 
   &--icon-only {
-    padding: calc(.625rem - 2px) .625rem;
+    padding: calc(.625rem - 2px) 1rem;
   }
 
   &__icon ~ &__text:not(:empty) {
@@ -142,22 +142,21 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
     }
 
     &:disabled:not(.go-button--loading) {
-      border: 1px solid $theme-light-bg-active;
+      @include disabled-states($theme-light-bg-active, 'dark');
+      border: 1px solid $base-light-tertiary;
 
       &:hover,
       &:focus {
-        border: 1px solid $theme-light-bg-active;
+        @include disabled-states($theme-light-bg-active, 'dark');
+        border: 1px solid $base-light-tertiary;
+        box-shadow: none;
       }
     }
   }
 
-  &--tertiary {
-    border: 1px solid $theme-light-bg;
-  }
-
-  &--secondary,
   &--tertiary {
     background: $theme-light-bg;
+    border: 1px solid $theme-light-bg;
     color: $theme-light-color;
 
     &:hover,
@@ -442,13 +441,13 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
     }
 
     &:disabled:not(.go-button--loading) {
-      border: 1px solid $theme-light-bg-active;
+      border: 1px solid $base-light-tertiary;
       border-left: 0;
 
       &:hover,
       &:focus {
         background: $theme-light-bg-hover;
-        border: 1px solid $theme-light-bg-active;
+        border: 1px solid $base-light-tertiary;
         border-left: 0;
         box-shadow: none;
       }
@@ -468,6 +467,7 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
     right: 0;
     top: calc(2rem + 2px);
     visibility: hidden;
+    white-space: nowrap;
 
     &--active {
       opacity: 1;
@@ -482,7 +482,6 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
     cursor: pointer;
     font-size: .875rem;
     font-weight: normal;
-    max-width: 10rem;
     padding: .75rem;
 
     &:hover {

diff --git a/projects/go-lib/src/lib/components/go-card/go-card.component.scss b/projects/go-lib/src/lib/components/go-card/go-card.component.scss
@@ -12,7 +12,6 @@
   &__header {
     display: flex;
     justify-content: space-between;
-    padding-bottom: 1rem;
   }
 
   &__action-list {

diff --git a/projects/go-lib/src/lib/components/go-file-upload/go-file-upload.component.ts b/projects/go-lib/src/lib/components/go-file-upload/go-file-upload.component.ts
@@ -1,4 +1,4 @@
-import { Component, Input, OnDestroy, OnInit } from '@angular/core';
+import { Component, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
 import { AbstractControl, FormArray, FormBuilder, FormGroup } from '@angular/forms';
 import { Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
@@ -20,6 +20,7 @@ export class GoFileUploadComponent extends GoFormBaseComponent implements OnInit
   @Input() isLoading: boolean = false;
   @Input() multiple: boolean = false;
   @Input() state: 'selecting' | 'selected' = 'selecting';
+  @ViewChild('filePicker') filePicker: any;
 
   ngOnInit(): void {
     this.fb = new FormBuilder();
@@ -51,6 +52,7 @@ export class GoFileUploadComponent extends GoFormBaseComponent implements OnInit
         this.filePreview.push(file.name);
       });
     }
+    this.filePicker.nativeElement.value = '';
   }
 
   removeFile(index: number): void {

diff --git a/projects/go-lib/src/lib/components/go-hint/go-hint.component.scss b/projects/go-lib/src/lib/components/go-hint/go-hint.component.scss
@@ -1,7 +1,8 @@
 @import '../../../../styles/variables';
 
 .go-hint {
-  font-size: .875rem;
+  font-size: .75rem;
+  font-style: italic;
   letter-spacing: $base-letter-spacing;
   line-height: 1rem;
   margin: $column-gutter--quarter 0;
@@ -43,7 +44,8 @@
 
   &__label {
     display: block;
-    font-size: .75rem;
+    font-size: 9px;
+    font-style: initial;
     font-weight: $weight-regular;
     margin-bottom: $column-gutter--quarter;
     text-transform: uppercase;

diff --git a/projects/go-lib/src/lib/components/go-modal/go-modal.component.scss b/projects/go-lib/src/lib/components/go-modal/go-modal.component.scss
@@ -6,7 +6,7 @@
   @include z-index(modal);
 
   align-items: center;
-  background: transparentize($base-dark, .1);
+  background: rgba($base-color, .5);
   display: flex;
   height: 100%;
   justify-content: center;

diff --git a/projects/go-lib/src/lib/components/go-modal/go-modal.component.ts b/projects/go-lib/src/lib/components/go-modal/go-modal.component.ts
@@ -65,7 +65,7 @@ export class GoModalComponent extends GoModalOptions implements OnInit, OnDestro
   loadComponent(): void {
     const componentFactory: ComponentFactory<{}> = this.componentFactoryResolver.resolveComponentFactory(this.currentComponent.component);
     const viewContainerRef: ViewContainerRef = this.goModalHost.viewContainerRef;
-
+    viewContainerRef.clear();
     const componentRef: ComponentRef<{}> = viewContainerRef.createComponent(componentFactory);
 
     Object.keys(this.currentComponent.bindings).forEach((key: string) => {

diff --git a/projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.scss b/projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.scss
@@ -4,7 +4,7 @@
 .go-off-canvas-backdrop {
   @include z-index(off-canvas);
 
-  background: rgba($base-dark, .5);
+  background: rgba($base-color, .5);
   height: 100vh;
   left: 0;
   position: fixed;

diff --git a/projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.ts b/projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.ts
@@ -93,6 +93,7 @@ export class GoOffCanvasComponent extends GoOffCanvasOptions implements OnInit,
       this.currentOffCanvasItem.component
     );
     const viewContainerRef: ViewContainerRef = this.goOffCanvasHost.viewContainerRef;
+    viewContainerRef.clear();
     const componentRef: ComponentRef<any> = viewContainerRef.createComponent(componentFactory);
 
     Object.keys(this.currentOffCanvasItem.bindings).forEach((key: string) => {

diff --git a/projects/go-lib/src/lib/components/go-progress-bar/go-progress-bar.component.html b/projects/go-lib/src/lib/components/go-progress-bar/go-progress-bar.component.html
@@ -0,0 +1,35 @@
+<div class="go-progress-bar" tabindex="-1">
+  <ng-container
+    *ngTemplateOutlet="mode === 'determinate' ? determinate : indeterminate"
+  >
+  </ng-container>
+</div>
+
+<ng-template #determinate>
+  <div class="go-progress-bar__determinate">
+    <span class="go-progress-bar__determinate__left-label">
+      {{ leftLabel }}</span
+    >
+    <div class="go-progress-bar__determinate--track">
+      <div
+        class="go-progress-bar__determinate--indicator"
+        [ngStyle]="{ width: indicatorWidth + '%' }"
+      ></div>
+    </div>
+    <span class="go-progress-bar__determinate__right-label">{{
+      rightLabel
+    }}</span>
+  </div>
+</ng-template>
+
+<ng-template #indeterminate>
+  <div class="go-progress-bar__indeterminate">
+    <div class="go-progress-bar__indeterminate--track"></div>
+    <div
+      class="go-progress-bar__indeterminate--indicator go-progress-bar__indeterminate--primary-indicator"
+    ></div>
+    <div
+      class="go-progress-bar__indeterminate--indicator go-progress-bar__indeterminate--secondary-indicator"
+    ></div>
+  </div>
+</ng-template>