Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7-dev] use the new ml pipeline #9

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Conversation

mnvoh
Copy link
Owner

@mnvoh mnvoh commented Mar 30, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The model at <root>/cameratokeyboard/model.pt is used, which is also commited into the repo.

Issue Number: #7

What is the new behavior?

  • Checks for new models trained by the CI and stored in S3
  • If a new version exists, downloads it to <user_data_dir>/c2k/models/<version>.pt
  • Upon running the app, automatically uses the latest version

Does this introduce a breaking change?

  • Yes
  • No

Other information

Closes #7

Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.40000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 94.15%. Comparing base (4ac1b0a) to head (c0b0ebd).

Files Patch % Lines
cameratokeyboard/model/model_downloader.py 84.00% 8 Missing ⚠️
cameratokeyboard/config.py 89.65% 3 Missing ⚠️
cameratokeyboard/model/train.py 94.44% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   79.86%   94.15%   +14.28%     
===========================================
  Files          18       20        +2     
  Lines         909     1009      +100     
===========================================
+ Hits          726      950      +224     
+ Misses        183       59      -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnvoh mnvoh merged commit a4670a9 into main Mar 30, 2024
2 checks passed
@mnvoh mnvoh deleted the 7-dev-use-the-new-ml-pipeline branch March 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: Use the new ML pipeline
2 participants