fix(vscode): panic when hovering over references in assignment (wingl…

…ang#4428)

Hovering over assignments with references (e.g. `this.x = 2` and hovering over `this` or `x`) caused a panic.

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

libs/wingc/src/lsp/hover.rs

@@ -77,9 +77,8 @@ impl<'a> HoverVisitor<'a> {
 		}
 	}
 
-	fn visit_type_with_member(&mut self, obj_type: TypeRef, property: &'a Symbol) {
+	fn visit_type_with_member(&mut self, obj_type: TypeRef, property: &'a Symbol, total_span: WingSpan) {
 		if property.span.contains(&self.position) {
-			let new_span = self.current_expr.unwrap().span.clone();
 			match &**obj_type.maybe_unwrap_option() {
 				Type::Optional(_) | Type::Anything | Type::Void | Type::Nil | Type::Unresolved | Type::Inferred(_) => {}
 
@@ -98,26 +97,26 @@ impl<'a> HoverVisitor<'a> {
 					if let Some((std_type, ..)) = self.types.get_std_class(&obj_type.to_string()) {
 						if let Some(c) = std_type.as_type() {
 							if let Some(c) = c.as_class() {
-								self.found = Some((new_span, docs_from_classlike_property(c, property)));
+								self.found = Some((total_span, docs_from_classlike_property(c, property)));
 							}
 						}
 					}
 				}
 
 				Type::Function(_) | Type::Enum(_) => {
 					self.found = Some((
-						new_span,
+						total_span,
 						Some(self.types.get_expr_type(self.current_expr.unwrap()).render_docs()),
 					));
 				}
 				Type::Class(c) => {
-					self.found = Some((new_span, docs_from_classlike_property(c, property)));
+					self.found = Some((total_span, docs_from_classlike_property(c, property)));
 				}
 				Type::Interface(c) => {
-					self.found = Some((new_span, docs_from_classlike_property(c, property)));
+					self.found = Some((total_span, docs_from_classlike_property(c, property)));
 				}
 				Type::Struct(c) => {
-					self.found = Some((new_span, docs_from_classlike_property(c, property)));
+					self.found = Some((total_span, docs_from_classlike_property(c, property)));
 				}
 			}
 		}
@@ -391,13 +390,25 @@ impl<'a> Visit<'a> for HoverVisitor<'a> {
 				if object.span.contains(&self.position) {
 					self.visit_expr(object)
 				} else {
-					self.visit_type_with_member(self.types.get_expr_type(object), property)
+					let total_span = WingSpan {
+						file_id: property.span.file_id.clone(),
+						start: object.span.start,
+						end: property.span.end,
+					};
+
+					self.visit_type_with_member(self.types.get_expr_type(object), property, total_span)
 				}
 			}
 			Reference::TypeMember { type_name, property } => {
 				if type_name.span.contains(&self.position) {
 					self.visit_user_defined_type(type_name)
 				} else {
+					let total_span = WingSpan {
+						file_id: property.span.file_id.clone(),
+						start: type_name.span.start,
+						end: property.span.end,
+					};
+
 					self.visit_type_with_member(
 						resolve_user_defined_type(
 							type_name,
@@ -406,6 +417,7 @@ impl<'a> Visit<'a> for HoverVisitor<'a> {
 						)
 						.unwrap_or(self.types.error()),
 						property,
+						total_span,
 					)
 				}
 			}
@@ -798,6 +810,20 @@ class T {
 		//^
 	}
 }
+"#
+	);
+
+	test_hover_list!(
+		class_init_this_field,
+		r#"
+class T {
+  stuff: num;
+
+  init() {
+    this.stuff = 1;
+         //^
+  }
+}
 "#
 	);
 }

libs/wingc/src/lsp/snapshots/hovers/class_init_this_field.snap

@@ -0,0 +1,14 @@
+---
+source: libs/wingc/src/lsp/hover.rs
+---
+contents:
+  kind: markdown
+  value: "```wing\npreflight stuff: num\n```"
+range:
+  start:
+    line: 5
+    character: 4
+  end:
+    line: 5
+    character: 14
+

libs/wingc/src/lsp/snapshots/hovers/static_stdtype_method.snap

@@ -10,5 +10,5 @@ range:
     character: 0
   end:
     line: 1
-    character: 4
+    character: 14