Skip to content

Commit

Permalink
fix(vscode): open in wing console icon broken (winglang#4472)
Browse files Browse the repository at this point in the history
<img width="359" alt="image" src="https://github.com/winglang/wing/assets/5547636/0a33157e-d8f6-4bef-8c31-d092228a1537">

On this PR:
<img width="359" alt="image" src="https://github.com/winglang/wing/assets/5547636/d9d31f85-a65e-4d64-91e5-f71f1aab7683">

## Checklist

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
polamoros authored Oct 9, 2023
1 parent d7c4c67 commit 9700b4d
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 14 deletions.
12 changes: 6 additions & 6 deletions apps/vscode-wing/.projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ const contributes: VSCodeExtensionContributions = {
extensions: [".w", ".wsim"],
configuration: "./language-configuration.json",
icon: {
light: "resources/icon-light.png",
dark: "resources/icon-dark.png",
light: "resources/winglang-symbol-dark.svg",
dark: "resources/winglang-symbol-light.svg",
},
},
],
Expand All @@ -126,16 +126,16 @@ const contributes: VSCodeExtensionContributions = {
command: "wing.openConsole",
title: "Open in Wing Console",
icon: {
light: "resources/icon-light.png",
dark: "resources/icon-dark.png",
light: "resources/winglang-symbol-light.svg",
dark: "resources/winglang-symbol-dark.svg",
},
},
{
command: "wing.openFile",
title: "Open source file",
icon: {
light: "resources/icon-light.png",
dark: "resources/icon-dark.png",
light: "resources/winglang-symbol-light.svg",
dark: "resources/winglang-symbol-dark.svg",
},
},
{
Expand Down
12 changes: 6 additions & 6 deletions apps/vscode-wing/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed apps/vscode-wing/resources/icon-dark.png
Binary file not shown.
Binary file removed apps/vscode-wing/resources/icon-light.png
Binary file not shown.
13 changes: 13 additions & 0 deletions apps/vscode-wing/resources/winglang-symbol-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions apps/vscode-wing/resources/winglang-symbol-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 6 additions & 2 deletions apps/vscode-wing/src/console/console-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,13 @@ export const createConsoleManager = (
light: Uri.joinPath(
context.extensionUri,
"resources",
"icon-light.png"
"winglang-symbol-light.svg"
),
dark: Uri.joinPath(
context.extensionUri,
"resources",
"winglang-symbol-dark.svg"
),
dark: Uri.joinPath(context.extensionUri, "resources", "icon-dark.png"),
};

webviewPanel.onDidDispose(async () => {
Expand Down

0 comments on commit 9700b4d

Please sign in to comment.