BUG: Fix bug with reading his_id from snirf #12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
drammock,
agramfort,
dengemann and
rob-luke
as code owners
|
@drammock should be good to go! |
drammock
approved these changes
Apr 2, 2024
Comment on lines
287
to
+289
| names = np.array(dat.get("nirs/metaDataTags/SubjectID")) | ||
| subject_info["first_name"] = _correct_shape(names)[0].decode("UTF-8") | ||
| names = _correct_shape(names)[0].decode("UTF-8") | ||
| subject_info["his_id"] = names |
There was a problem hiding this comment.
[nitpick] varname shouldn't be names if the content is an anonymous ID. Or is SubjectID sometimes containing actual names?
There was a problem hiding this comment.
Sometimes it contains just the concat of first middle last. The naming and stuff is meant to mirror the NIRX convention / use I think:
mne-python/mne/io/nirx/nirx.py
Line 330 in 0aef079
Comment on lines
+300
to
+302
| else: | ||
| # MNE < 1.7 used to not write the firstName tag, so pull it from names | ||
| subject_info["first_name"] = names.split("_")[0] |
There was a problem hiding this comment.
this strikes me as odd but if you're doing it I trust that it makes sense?
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Apr 15, 2024
* upstream/main: (50 commits) ENH: Improve OPM auditory dataset and example (mne-tools#12539) MAINT: Bump to latest pydata-sphinx-theme (mne-tools#12228) MRG: Simplify manual installation instructions a little by dropping explicit mention of (lib)mamba (mne-tools#12362) fix PSD weights handling when bad annotations present (mne-tools#12538) Fix phase loading (mne-tools#12537) align FFT windows to good data spans in psd_array_welch (mne-tools#12536) explicitly disallow multitaper in presence of bad annotations (mne-tools#12535) MAINT: Clean up PyVista contexts (mne-tools#12533) MAINT: Complete API change of ordered (mne-tools#12534) MAINT: Reinstall statsmodels and improve logging (mne-tools#12532) MAINT: Remove scipy.signal.morlet2 (mne-tools#12531) Update README badge links (mne-tools#12529) BUG: Fix bug with reading his_id from snirf (mne-tools#12526) [pre-commit.ci] pre-commit autoupdate (mne-tools#12524) Fix file format check in _check_eeglab_fname function (mne-tools#12523) MAINT: Reenable picard in pre testing (mne-tools#12525) MAINT: Bump to large resource class (mne-tools#12522) MAINT: Restore 2 jobs on Windows (mne-tools#12520) Add exclude_after_unique option to mne.io.read_raw_edf/read_raw_edf to search for exclude channels after making channel names unique (mne-tools#12518) Improve consistency of sensor types in code and documentation (mne-tools#12509) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to mne-tools/mne-nirs#546. But the short version is that SNIRF stores a
SubjectIDwhich maps nicely onto ourinfo["subject_info"]["his_id"]but we weren't setting it.