Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Commit

Permalink
fix and optimize docker-compose with ReactJS building (#306)
Browse files Browse the repository at this point in the history
* rm node-server/public static frontend assets

The previous build workflow involved manually building the ReactJS
frontend, and then stashing that in the node server.  @suyashkumar has
updated the docker-compose configuration to build this on-the-fly,
making these static assets unnecessary.

closes #304

* fix Docker build

For some reason, using node:latest on my Fedora 30 setup was failing
(issue #305), even though it manually would build the ReactJS frontend
outside of Docker.

Dropping back to using NodeJS 8.x appears to be working, so will limit
to that for now.

fixes #305
  • Loading branch information
mlp6 authored Jun 13, 2019
1 parent af55b64 commit d3bb72c
Show file tree
Hide file tree
Showing 54 changed files with 2 additions and 969 deletions.
2 changes: 1 addition & 1 deletion software/cloud-dashboard/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:latest
FROM node:8

# Initialize Workspace
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion software/cloud-dashboard/node-server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:latest
FROM node:8
WORKDIR /app
COPY . /app
RUN npm install
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion software/cloud-dashboard/node-server/public/index.html

This file was deleted.

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion software/cloud-dashboard/node-server/public/new/index.html

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

176 changes: 0 additions & 176 deletions software/cloud-dashboard/node-server/public/old/index.html

This file was deleted.

Loading

0 comments on commit d3bb72c

Please sign in to comment.