Testing: Adding ChooseAffiliation
component above InstitutionSelect
.
#403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The modal used for the
ChooseAffiliation
component is unsupported by versions of Safari older than 15.4, rendering the site unusable. The component has been redesigned to become a dropdown option underFilters
, similar to what is seen forLibrary Scope
, removing the need for a modal.This pull request resolves LIBSEARCH-899.
Anything else?
The new component no longer relies on cookies, and instead uses
localStorage
. This removed the need for theaffiliationCookieSetter
function and thereact-cookie
package.FlintAlerts
FlintAlerts
had several changes made:UserIsFlintAffiliated
has been moved intoFlintAlerts
, making the component unused and has been deleted.datastores
.state.affiliation.active
was being marked asundefined
on reload. It now defaults toaction
orlocalStorage
orundefined
.Testing
Ann Arbor|Flint
toggle in the website header?Affiliation
at the bottom of the filter options?