Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Adding ChooseAffiliation component above InstitutionSelect. #403

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erinesullivan
Copy link
Contributor

Overview

The modal used for the ChooseAffiliation component is unsupported by versions of Safari older than 15.4, rendering the site unusable. The component has been redesigned to become a dropdown option under Filters, similar to what is seen for Library Scope, removing the need for a modal.

This pull request resolves LIBSEARCH-899.

Anything else?

The new component no longer relies on cookies, and instead uses localStorage. This removed the need for the affiliationCookieSetter function and the react-cookie package.

FlintAlerts

FlintAlerts had several changes made:

  • It was converted to a functional component.
  • The functionality of UserIsFlintAffiliated has been moved into FlintAlerts, making the component unused and has been deleted.
  • The component has been moved to live under datastores.
  • When changing affiliations, state.affiliation.active was being marked as undefined on reload. It now defaults to action or localStorage or undefined.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Open the local site.
    • Look around the site and check to see if anything is broken.
    • Do you no longer see the Ann Arbor|Flint toggle in the website header?
    • Make a search in one of the datastores
      • Do you see Affiliation at the bottom of the filter options?
      • Is it set to one of the schools?
      • If you click on the other affiliation, does it reload the page?
      • If you click on the current affiliation, does the page not reload?
      • If you close the tab and reopen it, is it set to the affiliation you last selected?
      • Compare the same search to the live site. Do the same options still appear?

@erinesullivan erinesullivan self-assigned this Aug 30, 2023
@erinesullivan erinesullivan changed the title Adding ChooseAffiliation component above InstitutionSelect. Testing: Adding ChooseAffiliation component above InstitutionSelect. Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant