Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HathiTrust DEV-1303: Add USE_CATPROCIO env var #712

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Sep 6, 2024

We want to avoid calling 'sudo catprocio' when it isn't going to work; with a corresponding change in babel, this checks that the USE_CATPROCIO env var is set and only does sudo catprocio if so.

@aelkiss aelkiss requested a review from rrotter September 6, 2024 20:13
@aelkiss
Copy link
Member Author

aelkiss commented Sep 6, 2024

@aelkiss
Copy link
Member Author

aelkiss commented Sep 6, 2024

I also removed some unused cron jobs that are likely silently failing at the moment.

We want to avoid calling 'sudo catprocio' when it isn't going to work;
with a corresponding change in babel, this checks that the USE_CATPROCIO
env var is set and only does sudo catprocio if so.

Sets it both for apache and the imgsrv startup script -- since we are
separately setting env vars for imgsrv startup it certainly doesn't
hurt, even if some of the env vars may come through from apache.
Both have been retired and won't work even if they are present.
Copy link
Member

@rrotter rrotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Feel free to merge on Monday, or let me know if you'd like me to.

@aelkiss aelkiss merged commit 3f840bd into production Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants