Fix path for startup_imgsrv #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @moseshll |
|
(Long term, imgsrv should run in kubernetes, and then it would be using its own version of startup_imgsrv that's already in the repo -- https://github.com/hathitrust/babel/blob/main/imgsrv/bin/startup_imgsrv) |
|
@rrotter if you could get this merged when you have a chance I'd appreciate it -- thanks! |
rrotter
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change to watch the correct path for restarting imgsrv (see https://hathitrust.atlassian.net/browse/DEV-1317, https://github.com/hathitrust/babel/blob/main/bin/rsync.app.timestamp)
I don't love that these things are coupled, and maybe we should be deploying startup_imgsrv as part of babel, but right now this needs to be fixed here.