Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Specifying Custom cache_dir #245

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

siddk
Copy link
Contributor

@siddk siddk commented Aug 21, 2023

Hey folks - I love openflamingo but a common problem our team has is that saving big files to ~/.cache vs. other, directories with more space/locations shared with other users.

This PR adds back the cache_dir functionality in both OpenCLIP and Hugging Face, allowing one to specify a download location in the call to create_model_and_transforms.

I couldn't find requirements-dev.txt to run all the linting specified in the Makefile, but ran black and pylint to (hopefully) conform to the original codebase format.

@anas-awadalla
Copy link
Collaborator

Great! Thank you 😊.

@anas-awadalla anas-awadalla merged commit 8255fff into mlfoundations:main Aug 21, 2023
1 check passed
@siddk siddk deleted the custom-cache-dir branch August 22, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants