Fix token storage bug #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
VukW
previously approved these changes
Feb 19, 2024
There was a problem hiding this comment.
LGTM, concise and pretty solution
Right now setting tokens looks not so atomic, but in reality any solution of writing data to the file is never totally atomic. So, instead of bothering about protection there it would be much better to ensure that we read token safely & can rewrite tokens successfully if anything is broken with them (if file is empty, not exists, token is broken, you name it)
VukW
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
VukW
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.openand uses the built-inopenfor storing the tokens. It creates an empty file first, changes its permissions, then appends the token.This PR also Forces logout for authenticated users who try to login again (to prevent refresh token count build up; to not lose track of active refresh tokens without revoking them). This is not related to the storage bug, but it is better to be implemented.