Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes/features after BraTS2023 #490

Merged
merged 9 commits into from
Sep 26, 2023
Merged

fixes/features after BraTS2023 #490

merged 9 commits into from
Sep 26, 2023

Conversation

hasan7n
Copy link
Contributor

@hasan7n hasan7n commented Sep 26, 2023 •
edited
Loading

This PR contains added features and bug fixes worked on during supporting BraTS2023:

  • Use sha256 instead of sha1
  • Inspect mlcube's docker image hash from temporary files rather than parsing stdout
  • Persists predictions in storage
  • there was a bug in submitting mlcubes with additional files and no parameters file
  • the logs of inference runs and metrics runs are now stored
  • mlcubes of the challenges of BraTS2023 are added

hasan7n and others added 9 commits August 25, 2023 04:14
@hasan7n
Use sha256 for hashing (#481)
5c04e73 
* use sha256 instead of sha1 for hashing

* update integration tests with new hashes

* update test entities max name length to 64

* fix failing unittests

* fix linter issues
@hasan7n
Inspect image hash from file (#482)
a9dface 
* update mlcube version

* read hash from file instead of parsing stdout

* fix tests

* remove unusedimport
@hasan7n
fix bug in data prep
5e611d4
@hasan7n
add BraTS2023 dummy model
4e4cc54
@hasan7n
add BraTS2023 inpainting and segmentation metrics
c347c9b
@hasan7n
Persist Predictions Storage (#483)
14a609d 
* store predictions always and even if model fails

* fix/add unittests

* add integration tests

* fix linter issues
@hasan7n
Bugfix: Unpacking additional files fails
f7cd27d 
This fix creates the parent folder before renaming
the temporary additional files folder
@hasan7n
store model and metrics runs logs
dbb29ae
@hasan7n
add synthesis metrics MLCube
db89eb2
@hasan7n hasan7n requested a review from a team as a code owner September 26, 2023 19:30
@hasan7n hasan7n temporarily deployed to testing-external-code September 26, 2023 19:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@hasan7n hasan7n temporarily deployed to testing-external-code September 26, 2023 19:42 — with GitHub Actions Inactive
@hasan7n hasan7n merged commit 905e9fd into main Sep 26, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hasan7n