-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLCube container image hash checking & Disable network #472
Merged
hasan7n
merged 79 commits into
mlcommons:main
from
aristizabal95:mlcube-img-hash-checking
Aug 3, 2023
Merged
MLCube container image hash checking & Disable network #472
hasan7n
merged 79 commits into
mlcommons:main
from
aristizabal95:mlcube-img-hash-checking
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristizabal95
had a problem deploying
to
testing-external-code
July 28, 2023 22:00
— with
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
July 28, 2023 22:05
— with
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
July 28, 2023 22:09
— with
GitHub Actions
Failure
aristizabal95
temporarily deployed
to
testing-external-code
July 28, 2023 22:11
— with
GitHub Actions
Inactive
aristizabal95
temporarily deployed
to
testing-external-code
July 28, 2023 22:13
— with
GitHub Actions
Inactive
aristizabal95
temporarily deployed
to
testing-external-code
July 28, 2023 22:13
— with
GitHub Actions
Inactive
aristizabal95
temporarily deployed
to
testing-external-code
July 31, 2023 21:23
— with
GitHub Actions
Inactive
aristizabal95
temporarily deployed
to
testing-external-code
July 31, 2023 23:02
— with
GitHub Actions
Inactive
hasan7n
had a problem deploying
to
testing-external-code
August 2, 2023 04:25
— with
GitHub Actions
Failure
hasan7n
temporarily deployed
to
testing-external-code
August 2, 2023 05:12
— with
GitHub Actions
Inactive
hasan7n
temporarily deployed
to
testing-external-code
August 2, 2023 16:03
— with
GitHub Actions
Inactive
hasan7n
had a problem deploying
to
testing-external-code
August 3, 2023 18:43
— with
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: client
issues regarding the CLI
High Priority
Urgent tasks
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of recently added features on MLCube for ensuring reproducibility and reducing vulnerabilities on external code execution. This is done with the following 2 features:
mlcube inspect
, we can now get the hash of the container image (original image if converted) and compare against a ground truth on our server. This ensures users won't be able to change the image contents after submitting an MLCube.--network
flag during execution time. We're using this to disable network access, ensuring MLCubes won't be able to retrieve or send information to another location during execution.Closes #469.
TODO:
inspect
is on a pre-release, which is not yet installable throughrequirements.txt
)