-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker compose file #940
base: master
Are you sure you want to change the base?
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Looks good, but should we not be using this for all Docker builds? |
It's the same with this, IMO but in an easier way. |
Okay, then please provide clear examples of how this improves the existing docker workflow. |
I have created an example to demonstrate how to use it, but I have noticed that extra effort is required from the user to modify the compose.yaml file. Using the docker command line
Using the docker compose file.
You can run |
@hasan7n since you are far more familiar with docker than I am, what are you views on this? |
Fixes #875
Proposed Changes
You can check ref
you can run
to build and run your container
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.