Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three changes to
ModelRecord
this PR brings:1. Update model ids to match HF repo name
We rename
modelId
inwebllm.prebuiltAppConfig
to be the exact same as the HF repo name. For most models, that means we simply append-MLC
to themodelId
. For the low-context version of the model, we would have{HF-repo}-1k
, suggesting 1k context length.As a result, we rename Phi2 and phi1.5 models since their
modelId
did not match with the repo namePhi2-q4f32_1
→phi-2-q4f32_1-MLC
Phi1.5-q4f16_1
→phi-1_5-q4f16_1-MLC
2. Rename
model_url
andmodel_lib_url
tomodel
andmodel_lib
To better match with other platforms of MLC-LLM (e.g. iOS, Android), we rename the
ModelRecord
fields.3. Remove
resolve/main
frommodel
URLInstead of
"https://huggingface.co/mlc-ai/Llama-3-8B-Instruct-q4f16_1-MLC/resolve/main/"
, we now make it"https://huggingface.co/mlc-ai/Llama-3-8B-Instruct-q4f16_1-MLC/"
; note the trailing/
will be appended by us if it is not there.Example
As an example, we would have:
instead of