Skip to content

Commit

Permalink
Fix s3.get_subdevices() (#790)
Browse files Browse the repository at this point in the history
* Fix s3.get_subdevices()

* Fix docstring
  • Loading branch information
felipediel authored Apr 11, 2024
1 parent eb0f98a commit 24b9d30
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions broadlink/hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,34 @@ class s3(Device):
TYPE = "S3"
MAX_SUBDEVICES = 8

def get_subdevices(self) -> list:
"""Return the lit of sub devices."""
def get_subdevices(self, step: int = 5) -> list:
"""Return a list of sub devices."""
total = self.MAX_SUBDEVICES
sub_devices = []
step = 5
seen = set()
index = 0

for index in range(0, self.MAX_SUBDEVICES, step):
while index < total:
state = {"count": step, "index": index}
packet = self._encode(14, state)
resp = self.send_packet(0x6A, packet)
e.check_error(resp[0x22:0x24])
resp = self._decode(resp)

sub_devices.extend(resp["list"])
if len(sub_devices) == resp["total"]:
for device in resp["list"]:
did = device["did"]
if did in seen:
continue

seen.add(did)
sub_devices.append(device)

total = resp["total"]
if len(seen) >= total:
break

index += step

return sub_devices

def get_state(self, did: str = None) -> dict:
Expand Down

0 comments on commit 24b9d30

Please sign in to comment.