Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search-row: Use GtkExpression lookups in Blueprint #554

Merged
merged 2 commits into from
Feb 5, 2024
Merged

search-row: Use GtkExpression lookups in Blueprint #554

merged 2 commits into from
Feb 5, 2024

Conversation

oscfdezdz
Copy link
Collaborator

@oscfdezdz oscfdezdz commented Jan 12, 2024 •
edited
Loading

I also took the opportunity to run the new formatter (blueprint-compiler format).

It remains to do the same with extension-row, which will be better to do in or after #517.

mjakeman
mjakeman approved these changes Feb 5, 2024
View reviewed changes
Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Look at that diff :D

I'll rework #517 in the coming days to leverage GtkExpression lookups. Hopefully it can take a lot of the cruft out of detail-view.

@mjakeman mjakeman merged commit 7e2e0f1 into master Feb 5, 2024
1 check passed
@mjakeman mjakeman deleted the oscfdezdz/search-row-expression-lookup branch February 5, 2024 12:23
@oscfdezdz
Copy link
Collaborator Author

There has to be some way to do the same with action-target and uuid, but I haven't found how to use a GVariant format string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjakeman mjakeman mjakeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscfdezdz @mjakeman