Print rule's documentation links #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
added
Type: Feature
|
mizdra
changed the title
|
After some investigation, it turns out that it's not a bug of |
mizdra
force-pushed
the
use-table-package
branch
from
abf576a
to
56c425f
Compare
mizdra
force-pushed
the
use-table-package
branch
from
cc1e195
to
d89d18e
Compare
mizdra
force-pushed
the
use-table-package
branch
from
897d3e2
to
eaed562
Compare
mizdra
force-pushed
the
use-table-package
branch
from
eaed562
to
73475a5
Compare
mizdra
commented
Mar 22, 2022
| // - However, due to the specifications of Node.js, the decision does not work well on worker_threads. | ||
| // - So here we use a special environment variable to force the printing mode to be switched. | ||
| // ref: https://github.com/chalk/supports-color/issues/97, https://github.com/nodejs/node/issues/26946 | ||
| FORCE_HYPERLINK: terminalLink.isSupported ? '1' : '0', |
mizdra
commented
Mar 22, 2022
Comment on lines
+40
to
+52
| // The `table` package does not print the terminal link correctly. So eslint-interactive avoids | ||
| // this by first printing the table in the `table` package without the link, | ||
| // then converting it to a link by replacement. | ||
| // ref: https://github.com/gajus/table/issues/113 | ||
| let result = table.table(rows); | ||
| ruleStatistics.forEach((ruleStatistic) => { | ||
| const { ruleId } = ruleStatistic; | ||
| const ruleMetaData = data?.rulesMeta[ruleId]; | ||
| const ruleCell = ruleMetaData?.docs?.url | ||
| ? terminalLink(ruleId, ruleMetaData?.docs.url, { fallback: false }) | ||
| : ruleId; | ||
| result = result.replace(` ${ruleId} `, ` ${ruleCell} `); | ||
| }); |
|
LGTM |
mizdra
removed
help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #89
blocked by:
chalk/supports-color#97, gajus/table#113Try it out
$ yarn run devBefore
After