Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Typescript 5 #103

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: upgrade to Typescript 5 #103

merged 1 commit into from
Feb 23, 2024

Conversation

jsalvata
Copy link
Contributor

@jsalvata jsalvata commented Feb 23, 2024

Note - Since this is a public repository, make sure that we're not publishing private data in the code, commit comments, or this PR.

Note for reviewers - Please add a 2nd reviewer if the PR affects more than 15 files or 100 lines (not counting
package-lock.json), if it incurs significant risk, or if it is going through a 2nd review+fix cycle.

📚 Context/Description Behind The Change

Upgrade to Typescript 5.

🚨 Potential Risks & What To Monitor After Deployment

None perceived.

🧑‍🔬 How Has This Been Tested?

  • npm-linked on a TS5 package which was throwing Parsing error: Invalid value for lib provided: es2022 errors.
  • npm-linked on app (which is TS4) and checked linting works.

🚚 Release Plan

Merge.

@jsalvata jsalvata merged commit 7a413c2 into master Feb 23, 2024
4 checks passed
@jsalvata jsalvata deleted the jordi/typescript-5 branch February 23, 2024 13:25
@jsalvata
Copy link
Contributor Author

Tested in app using npm install --save-dev eslint-config-mixmax@latest.
Works well (lint throws 30-something errors, but they are legitimate, caused by some previous change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants