-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include mitxonline email opt in data #1008
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below. Also a question, did we not include every model in _irx_mitxonline__models.yml? I don't see irx__mitxonline__openedx__bigquery__email_opt_in
in _irx_mitxonline__models.yml for example
@@ -1,5 +1,5 @@ | |||
with email_opt_in as ( | |||
select * from {{ source('ol_warehouse_raw_data','raw__irx__edxorg__bigquery__email_opt_in') }} | |||
select * from {{ ref('int__mitxonline__bulk_email_optin') }} | |||
) | |||
|
|||
select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these fields listed here are in int__mitxonline__bulk_email_optin
. If you run this model, there should be errors. I think we need to replace all the fields with the correct names.
select
is_opted_in_for_email
, course_id
, full_name
, preference_set_datetime
, user_id
from email_opt_in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, I have updated the column names to the correct ones and also added the yaml for that table. Many of the new models that are not included in the iml file could not be processed by dbt-coves. I was going to write the definitions out manually but since we are tabling this work for now, I figured we could revisit that in the future when this becomes a priority again.
LGTM now |
…e not iterating on course_id.
@quazi-h The new changes look fine. But just wanted to point out that |
I asked @pdpinch about xPro email opt in. It sounded like xPro handle this data differently, but no one has asked about it for xPro. So I am not sure how you want to handle |
What's the status of this? It's been open for a long time. |
Pulling email opt in data from the correct dbt model instead of the data from IRx.