Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mitxonline email opt in data #1008

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Include mitxonline email opt in data #1008

wants to merge 5 commits into from

Conversation

quazi-h
Copy link
Contributor

@quazi-h quazi-h commented Feb 12, 2024

Pulling email opt in data from the correct dbt model instead of the data from IRx.

Copy link
Contributor

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment below. Also a question, did we not include every model in _irx_mitxonline__models.yml? I don't see irx__mitxonline__openedx__bigquery__email_opt_in in _irx_mitxonline__models.yml for example

@@ -1,5 +1,5 @@
with email_opt_in as (
select * from {{ source('ol_warehouse_raw_data','raw__irx__edxorg__bigquery__email_opt_in') }}
select * from {{ ref('int__mitxonline__bulk_email_optin') }}
)

select
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these fields listed here are in int__mitxonline__bulk_email_optin. If you run this model, there should be errors. I think we need to replace all the fields with the correct names.

select
    is_opted_in_for_email
    , course_id
    , full_name
    , preference_set_datetime
    , user_id
from email_opt_in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I have updated the column names to the correct ones and also added the yaml for that table. Many of the new models that are not included in the iml file could not be processed by dbt-coves. I was going to write the definitions out manually but since we are tabling this work for now, I figured we could revisit that in the future when this becomes a priority again.

@rachellougee
Copy link
Contributor

LGTM now

@rachellougee
Copy link
Contributor

@quazi-h The new changes look fine. But just wanted to point out that irx__xpro__openedx__bigquery__email_opt_in doesn't really contain the open edx data from xPro. The underlying table raw__irx__edxorg__bigquery__email_opt_in is mostly for edX.org. There are only a couple of xPro courses that are old data in 2018. You probably need to source it directly from raw__xpro__openedx__mysql__bulk_email_optout and then do similar logic as int__mitxonline__bulk_email_optin

@rachellougee
Copy link
Contributor

rachellougee commented Feb 16, 2024

I asked @pdpinch about xPro email opt in. It sounded like xPro handle this data differently, but no one has asked about it for xPro. So I am not sure how you want to handle irx__xpro__openedx__bigquery__email_opt_in but we probably shouldn't pass around the data he gave to us. That said, it doesn't have to be handled in this PR.

@pdpinch
Copy link
Member

pdpinch commented Sep 19, 2024

What's the status of this? It's been open for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants