GlobalR/GlobalRX/GlobalRY Gates #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great to see the Global rot gates! could you add tests for those three gates? |
|
Finally have some notable progress! Turns out that my circuit was correct, I just had an aliasing issue. The gates should be good now! |
01110011011101010110010001101111
marked this pull request as ready for review
|
I don’t really know why 3.7 is consistently failing with a syntax error at |
|
Thank you GenericP3rson for your contributions! I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the GlobalR/RX/RY General Gates as layers, similar to the GlobalR Gates from Qiskit