Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

文字を重ねるMFMを追加 #13638

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Mar 30, 2024

What

新しいMFM$[overlap ... ...]を追加します。

  • 要素を下から上に重ねて表示します
  • 要素はデフォルトでは空白区切りです。.SEP属性で区切り文字をspace(空白)、lf(改行)、semicoloncommaから選べます。

Why

image

Additional info (optional)

名前はoverlap以外にoverlaylayerpileといった案がありました。要望次第で変える可能性あり

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

* add overlap

* fix

* fix and add SEP

* fix sep

* fix

* debug

* fix

* fix

* fix

* fix

* lint
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 34.48276% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 77.89%. Comparing base (8f415d6) to head (60cb874).
Report is 12 commits behind head on develop.

Files Patch % Lines
...src/components/global/MkMisskeyFlavoredMarkdown.ts 29.62% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13638       +/-   ##
============================================
+ Coverage    66.20%   77.89%   +11.68%     
============================================
  Files          990      184      -806     
  Lines       115894    25407    -90487     
  Branches      4477      485     -3992     
============================================
- Hits         76729    19790    -56939     
+ Misses       39133     5610    -33523     
+ Partials        32        7       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

  • $[position ]で代用できそうな気もする
  • 文字幅が違った場合はどうなる?

@FineArchs
Copy link
Contributor Author

$[position ]で代用できそうな気もする

実際今は$[position ]がその役割を果たしていることが多いとは思いますが、このやり方では絵文字ひとつ分の空白領域が発生し、しばしばレイアウトの崩れに繋がっています。

文字幅が違った場合はどうなる?

左揃えで重なる想定です。

@syuilo
Copy link
Member

syuilo commented Apr 6, 2024

中央揃えで良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants