-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
9 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e78110a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--X14
を消すのは不自然なので置いとくだけ置いといたほうがいいかも(もしくはX系を全部消すか)--nav-bg-transparent
はstyle.scssに定義し直したほうが良い可能性があるe78110a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不自然な理由って何かしら
たまたま一緒なだけだからそれを共通化するのは悪手
e78110a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X14を消すのが不自然というよりは、
X14を消すともともとX14で変更できていた部分がカスタムテーマによって変更できなくなるのではないかしら
(カスタムテーマの互換性がなくなりRefactorよりBREAKING)
e78110a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X系は変更されることを意図してないやつだからまぁ
e78110a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(だとしたら変更されることを意図してないのが明文化されていなかったので使ってる人はいなくはなさそうそうだしCHANGELOGにはしておいた方が混乱は少なさそう)