Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breakout Rooms] Release facilitator controls when last room is deleted #237

Closed
wants to merge 9 commits into from

Conversation

dfosco
Copy link
Contributor

@dfosco dfosco commented Dec 13, 2023

Review once #235 is merged is rebased here.

Might be impacted by realtime storage propagation issue.

@dfosco dfosco requested a review from a team as a code owner December 13, 2023 09:59
@dfosco dfosco marked this pull request as draft December 13, 2023 09:59
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 11:10am
webhooks-manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 11:10am

Daniel Fosco and others added 8 commits January 24, 2024 12:10
* Fix UI on empty state button

* Fix list of validations to always show missing steps

* Improve style in validations

* Make copy in user(s) splitting block dynamic

* Update 'Waiting room' copy on user selection dropdown

* UI and copy fixes in Room block

* Button size adjusted in waiting room

* Improve copy and UI for frame selection

* Fix rooms container height

* Fix copy

* Increase timer limit and add +5min option

* CSS fixes

* Remove CSS nesting

* Update toast copy

* Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx

Co-authored-by: Mettin Parzinski <[email protected]>

* Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx

Co-authored-by: Mettin Parzinski <[email protected]>

* Update examples/breakout-rooms/src/components/RoomConfig/RoomConfig.tsx

Co-authored-by: Frederico Estrela <[email protected]>

* Iterate frame title rendering when set to room

* Update styles

* Update relative timer rendering to change timer button text
Update finish session button variant

* Improve styles and dropdown separator

* One more style fix

* One more more style fix

* Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx

Co-authored-by: Mettin Parzinski <[email protected]>

* Fix broken copy

* Add CSS class to avoid li+li

---------

Co-authored-by: Mettin Parzinski <[email protected]>
Co-authored-by: Frederico Estrela <[email protected]>
* adding methods with line numbers

* remove attention from included features

* Update examples/breakout-rooms/README.md

Co-authored-by: Mettin Parzinski <[email protected]>

* adding yarn format linting

---------

Co-authored-by: Mettin Parzinski <[email protected]>
* add in missing storage collection methods

* add in missing storage collection methods
* adding in standardized methods to the included features section

* adding small update to standardize youtube room app example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants