Support for pax global extended headers #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
pax-global-extended-headers
branch
3 times, most recently
from
fab7533
to
810e173
Compare
MisterDA
changed the title
MisterDA
force-pushed
the
pax-global-extended-headers
branch
from
810e173
to
bb56a58
Compare
|
Rebased on 2.4.0. |
MisterDA
commented
Apr 14, 2023
reynir
reviewed
Apr 17, 2023
Co-authored-by: Reynir Björnsson <[email protected]>
Fix using globals discovered when looping in archives.
|
Thanks! |
reynir
reviewed
Apr 28, 2023
| >>= fun () -> | ||
| really_write fd (Header.zero_padding pax) | ||
|
|
||
| let write ?level ?global header fd = |
There was a problem hiding this comment.
After reading this again I'm not sure I like the ?global argument. It's unclear if this is to keep track of the global extended header state (which it is not), and passing the same global value would lead to writing the same global extended header multiple times. This interface also doesn't allow writing an "empty" tar archive with just a comment, for example.
I think I would prefer another function write_global that takes a Tar.Header.Extended.t and does the required serializations and writes it to output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfinished work.PoC for supporting pax global extended headers. They introduce global state, which needs to be threaded to calls to
HR.read, breaking the API.The change is somewhat important, so I haven't completed the work.Any thoughts? :-)