Rpc_genfake.{gentest,genall}: avoid crash on recursive types #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm opening another PR to fix the remaining problems. Now that OCaml has a Seq module we can limit the number of combinations we generate (instead of m^n) which avoids the other problem I was having. |
mseri
reviewed
Feb 29, 2024
mseri
approved these changes
Feb 29, 2024
Attempting to call 'genall' on a recursive type would either result in an OOM kill, because it'd recurse infinitely trying to generate testcases. When recursion depth is negative return the empty list instead of generating recursively and taking the first. Signed-off-by: Edwin Török <[email protected]>
Signed-off-by: Edwin Török <[email protected]>
|
Rebased on top of @Vincent-lau 's PR to make the CI pass, and applied the docstring suggestion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to define some nice recursive types, but the test generator ended up using a lot of memory, until the system started swapping (and I assume it would've eventually gotten OOM killed).
Attempting to call 'genall' on a recursive type would either result in an OOM kill, because it'd recurse infinitely trying to generate testcases. When recursion depth is negative return the empty list instead of generating recursively and taking the first.
There are more things to fix here, because although the testcase I added here now works, the original type(s) that I created still OOM trying to generate stacks (but stack depth seems fine).