Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable metrics for OCaml 5.2 #842

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

Firobe
Copy link
Member

@Firobe Firobe commented Sep 11, 2024

Use a version of mirage-memtrace compatible with OCaml 5.2 (mirroring similar changes on janestreet/memtrace#22). The underlying statmemprof isn't available before 5.3, but this allows us to at least collect all the other stats in mirage-monitoring (including GC).

Now we can use the original Dockerfile, and just add pins for ocaml-solo5 and memtrace-mirage. This also allows passing the same flags at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant