Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a version of
mirage-memtrace
compatible with OCaml 5.2 (mirroring similar changes on janestreet/memtrace#22). The underlyingstatmemprof
isn't available before 5.3, but this allows us to at least collect all the other stats inmirage-monitoring
(including GC).Now we can use the original Dockerfile, and just add pins for
ocaml-solo5
andmemtrace-mirage
. This also allows passing the same flags at runtime.