Use the Ipaddr external library and remove the homebrew equivalent.

This syncs direct with socket.
mirage · Aug 9, 2013 · 369d5de · 369d5de
1 parent f535fd6
commit 369d5de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,7 @@
+0.9.4 (09-August-2013):
+* Use the `Ipaddr` external library and remove the homebrew
+  equivalents in `Nettypes`.
+
 0.9.3 (18-July-2013):
 * Changes in module Manager: Removed some functions from the `.mli
   (plug/unplug) and added some modifications in the way the Manager

diff --git a/direct/lib/ethif.ml b/direct/lib/ethif.ml
@@ -77,7 +77,8 @@ let writev t bufs =
 
 let create netif =
   let ipv4 = fun (_:Cstruct.t) -> return () in
-  let mac = Macaddr.of_bytes_exn (OS.Netif.mac netif) in
+  (* TODO: there's a race here if the MAC can change in the future *)
+  let mac = OS.Netif.mac netif in
   let arp =
     let get_mac () = mac in
     let get_etherbuf () = OS.Netif.get_writebuf netif in