Add configurable httpx request timeout and increase default #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkers
force-pushed
the
make-httpx-timeout-configurable
branch
from
e4b11ed
to
f3ad95e
Compare
ammar92
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Nice work 👍 Just a few things:
- The setting for Rocky seems to be named differently, why's that?
- I suggest using a nullable float type for the timeout, since that's what
httpxand most other request libraries accept. A float gives a bit more freedom and an int isn't necessarily easier, in fact you could still pass an integer and it will be implicitly cast to a float. And nullable for passingNones, which explicitly means no timeout and could still be a useful setting.
octopoes/octopoes/xtdb/client.py
Outdated
| base_url=base_url, headers={"Accept": "application/json"}, transport=(httpx.HTTPTransport(retries=3)) | ||
| base_url=base_url, | ||
| headers={"Accept": "application/json"}, | ||
| transport=(httpx.HTTPTransport(retries=3)), |
There was a problem hiding this comment.
Not your code, but the outer parentheses are redundant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes the timeout for outgoing requests configurable and increases the default timeout to 30.
QA notes
This touches most requests between services, so we should just test if OpenKAT in general still works.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.