Add bulk actions on report overview #3777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vws/nl-kat-coordination into feat/bulk-actions-on-report-overview
…vws/nl-kat-coordination into feat/bulk-actions-on-report-overview
ammar92
reviewed
Oct 31, 2024
| for subreport in subreports: | ||
| self.recreate_report(subreport, parent_ooi) | ||
|
|
||
| def rename_reports(self, report_references: list[str]) -> None: |
There was a problem hiding this comment.
A few things:
- The messages here are a bit misleading, because there's no way to find out what message belongs to what report reference?
- On success you would spam a few "Report names changed successfully." messages on the view, you probably want to do that only once when it actually succeeds?
Also, the message "Report names changed successfully." is misleading
|
|
||
| observed_at = datetime.now(timezone.utc) | ||
|
|
||
| bytes_data = self.get_report_data_from_bytes(report_ooi) |
There was a problem hiding this comment.
Suggested change
| bytes_data = self.get_report_data_from_bytes(report_ooi) | |
| report_data = self.get_report_data_from_bytes(report_ooi) |
|
|
||
| bytes_data = self.get_report_data_from_bytes(report_ooi) | ||
|
|
||
| new_bytes_id = self.bytes_client.upload_raw( |
There was a problem hiding this comment.
Suggested change
| new_bytes_id = self.bytes_client.upload_raw( | |
| raw_id = self.bytes_client.upload_raw( |
| def delete_reports(self, report_references: list[str]) -> None: | ||
| reports_selected = self.request.GET.get("report", "") | ||
| if reports_selected == "all": | ||
| all_reports = self.get_queryset()[:] # must be sliced |
There was a problem hiding this comment.
Why does it need to be sliced?
Suggested change
| all_reports = self.get_queryset()[:] # must be sliced | |
| all_reports = list(self.get_queryset()) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a drop down button with several actions on the report history page. The user needs to make a selection from the list of reports first, using the checkboxes.
Issue link
Closes #3379 and #3388
QA notes
Select one or more reports from the list using the checkboxes in front. In addition, also use the "select all" for testing purposes. And then select either delete or rename from the "actions" drop down and preform the action in the modal and submit the modal.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.