Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix first order dangling affirmation delete #3682

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Fix first order dangling affirmation delete #3682

merged 15 commits into from
Oct 16, 2024

Conversation

originalsouth
Copy link
Contributor

@originalsouth originalsouth commented Oct 14, 2024 •
edited
Loading

Changes

Fix first order dangling affirmation delete (credits go to @underdarknl)

Issue link

Should fix #3585, #3598 mostly

Demo

N/A

QA notes

Check if all findings are affirmed (i.e. not pending).

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth added bug Something isn't working octopoes Issues related to octopoes labels Oct 14, 2024
@originalsouth originalsouth requested a review from a team as a code owner October 14, 2024 10:58
@originalsouth originalsouth linked an issue Oct 14, 2024 that may be closed by this pull request
Object reference not found in Octopoes #3598
Closed
dekkers
dekkers reviewed Oct 14, 2024
View reviewed changes
octopoes/octopoes/core/service.py Outdated Show resolved Hide resolved
octopoes/octopoes/core/service.py Outdated Show resolved Hide resolved
ammar92
ammar92 previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and great test 👍

octopoes/tests/integration/test_ooi_deletion.py Outdated Show resolved Hide resolved
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Onboarding works, added an extra hostname and enabled a bunch of boefjes. All seem to run and complete and the findings all resolve. We will probably run into bugs at a later point in time, but looks good for now.

What doesn't work:

n/a

Bug or feature?:

n/a

@originalsouth
Copy link
Contributor Author

We will probably run into bugs at a later point in time, but looks good for now.

We are supposed to get less bugs not more...

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@underdarknl underdarknl merged commit 0f31898 into main Oct 16, 2024
31 of 32 checks passed
@underdarknl underdarknl deleted the fix/first-order-dangling-affirmation-delete branch October 16, 2024 12:16
jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
@jpbruinsslot
Merge branch 'main' into chore/mula/documentation
63b2ad4 
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers left review comments

@underdarknl underdarknl underdarknl approved these changes

@ammar92 ammar92 ammar92 left review comments

Assignees
No one assigned
Labels
bug Something isn't working octopoes Issues related to octopoes
Projects
KAT
Status: Done
Milestone
No milestone
5 participants
@originalsouth @stephanie0x00 @dekkers @underdarknl @ammar92