Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action should trigger if workflow definition changes #3680

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Oct 14, 2024

Changes

If the github workflow file changes, we should run the workflow to verify the changes. For workflow that trigger on a specific path this means we also need to list the workflow file under the paths to trigger it. This PR adds it to all the workflows where this was missing.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner October 14, 2024 10:13
@dekkers dekkers self-assigned this Oct 15, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. I always assumed a workflow edit would trigger itself automatically

Copy link

sonarcloud bot commented Oct 16, 2024

@underdarknl underdarknl merged commit 718d097 into main Oct 16, 2024
22 checks passed
@underdarknl underdarknl deleted the action-trigger-on-itself branch October 16, 2024 11:13
jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants