Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 1.17.rst #3631

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Create 1.17.rst #3631

merged 7 commits into from
Oct 9, 2024

Conversation

underdarknl
Copy link
Contributor

add 1.17 release notes for docs site.

Changes

We forgot to add this.

QA notes

Spellcheck, grammar check, links check.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

add 1.17 release notes for docs site.
@underdarknl underdarknl requested a review from a team as a code owner October 8, 2024 07:30
@underdarknl underdarknl added the documentation Improvements or additions to documentation label Oct 8, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few spelling suggestions, but looks good otherwise

docs/source/release_notes/1.17.rst Outdated Show resolved Hide resolved
docs/source/release_notes/1.17.rst Show resolved Hide resolved
docs/source/release_notes/1.17.rst Show resolved Hide resolved
docs/source/release_notes/1.17.rst Outdated Show resolved Hide resolved
ammar92
ammar92 previously approved these changes Oct 8, 2024
Add text before emoticon pushpin such that it renders.
Copy link

sonarcloud bot commented Oct 9, 2024

@dekkers dekkers merged commit a676f87 into main Oct 9, 2024
18 checks passed
@dekkers dekkers deleted the feat/1.17-release-notes branch October 9, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants