Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ducktape solutions for #3585 #3626

Closed
wants to merge 6 commits into from

Conversation

originalsouth
Copy link
Contributor

Changes

Ducktape solutions for #3585

This patch:

Issue link

#3585

Demo

N/A

QA notes

  • All affirmations should not be pending in a steady state
  • In VisualOctopoesStudio++ there should not be a any dangling objects

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues (see Data inconsistencies in Octopoes: a proposal to retire celery and validate the model continuously  #3585).
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth requested a review from a team as a code owner October 7, 2024 13:34
@originalsouth originalsouth added bug Something isn't working octopoes Issues related to octopoes labels Oct 7, 2024
@noamblitz
Copy link
Contributor

This seems to be the best solution to unblock regressions on main so we can release.

Copy link

sonarcloud bot commented Oct 7, 2024

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good. There are no dangling objects. All the findings are now resolved into a severity instead of Pending. Scanned multiple hosts and enabled a lot of boefjes to verify. Report generation also works.

What doesn't work:

N/a

Bug or feature?:

n/a

@underdarknl
Copy link
Contributor

Consensus is not to merge this, but revert the earlier fix. A more in depth solution should rely on xtdb2's features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working octopoes Issues related to octopoes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants