Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocky worker service to debian packages #3619

Merged
merged 15 commits into from
Oct 11, 2024

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Oct 3, 2024

Changes

This step should add the rocky worker service to the Debian packages as well.

Issue link

Demo

QA notes

We should test the report generation flow on a Debian installation. Edit: @dekkers offered help in the comments below with testing the Debian packages and production docker setup if needed 🙏


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype self-assigned this Oct 3, 2024
@Donnype Donnype requested a review from a team as a code owner October 3, 2024 14:27
@underdarknl
Copy link
Contributor

Good catch!

@dekkers
Copy link
Contributor

dekkers commented Oct 3, 2024

We should also add this to docker-compose.release-example.yml and https://docs.openkat.nl/installation_and_deployment/containers.html#container-commands and create an entrypoint so you can specify a simple CMD like we do for boefjes and octopoes containers. This also gives us the freedom to easily change the worker command in the future.

ammar92
ammar92 previously approved these changes Oct 4, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks

@dekkers
Copy link
Contributor

dekkers commented Oct 4, 2024

LGTM, moved to QA. Let me know if any help is needed with testing the Debian or example production container setup.

Copy link

sonarcloud bot commented Oct 11, 2024

@dekkers
Copy link
Contributor

dekkers commented Oct 11, 2024

I deployed the Debian packages and created a scheduled report. With the fixes I have already pushed the rocky worker starts and fetches the scheduled report job.

@underdarknl underdarknl merged commit 9068e7b into main Oct 11, 2024
28 checks passed
@underdarknl underdarknl deleted the feature/rocky-worker-service-for-debian-packages branch October 11, 2024 12:55
jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants