Skip to content

Commit

Permalink
Dont yield all snyk findings when no version was found (#3431)
Browse files Browse the repository at this point in the history
Co-authored-by: stephanie0x00 <[email protected]>
  • Loading branch information
noamblitz and stephanie0x00 authored Sep 9, 2024
1 parent a7ca00d commit a11a739
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -486,5 +486,10 @@
"source": "https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers",
"impact": "Nonstandard headers may not be supported by all browsers and may not provide the security that is expected.",
"recommendation": "Remove the nonstandard headers from the response."
},
"KAT-SOFTWARE-VERSION-NOT-FOUND": {
"description": "The version of the software is not found.",
"risk": "recommendation",
"recommendation": "There was no version found for this software but there are known vulnerabilities for this software."
}
}
11 changes: 10 additions & 1 deletion boefjes/boefjes/plugins/kat_snyk/normalize.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def run(input_ooi: dict, raw: bytes) -> Iterable[NormalizerOutput]:
elif not results["table_vulnerabilities"] and not results["cve_vulnerabilities"]:
# no vulnerabilities found
return
else:
if software_version:
for vuln in results["table_vulnerabilities"]:
snyk_ft = SnykFindingType(id=vuln.get("Vuln_href"))
yield snyk_ft
Expand All @@ -40,6 +40,15 @@ def run(input_ooi: dict, raw: bytes) -> Iterable[NormalizerOutput]:
ooi=pk_ooi,
description=vuln.get("Vuln_text"),
)
if not software_version and (results["table_vulnerabilities"] or results["cve_vulnerabilities"]):
kat_ooi = KATFindingType(id="KAT-SOFTWARE-VERSION-NOT-FOUND")
yield kat_ooi
yield Finding(
finding_type=kat_ooi.reference,
ooi=pk_ooi,
description="There was no version found for this software. "
"But there are known vulnerabilities for some versions.",
)

# Check for latest version
latest_version = ""
Expand Down

0 comments on commit a11a739

Please sign in to comment.