This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feat(COR-1765): ZKH in beeld – gemiddelde bedbezetting per dag #4842

Merged

VWSCoronaDashboard30 merged 6 commits into develop from feature/COR-1765_ZKH-in-beeld-gemiddelde-bedbezetting-per-dag

Aug 25, 2023

Contributor

VWSCoronaDashboard30 commented Aug 15, 2023

Changed the schemas to accept new properties.
Enhanced BorderedKpiSectionProps to accept a date range.
Swapped the new metrics with the old ones.


          feat(COR-1765): Added changes, expecting data

90c670a

VWSCoronaDashboard30 requested review from Jorrik-Klijnsma-Work, Amber-Taal-Work, APW26, ben-van-eekelen and VWSCoronaDashboard35

August 15, 2023 13:37

VWSCoronaDashboard30 added Hold Awaiting Data labels

APW26 reviewed

View reviewed changes

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

packages/app/schema/nl/intensive_care_lcps.json Show resolved Hide resolved

packages/app/src/components/kpi/types.ts Outdated Show resolved Hide resolved

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved


          feat(COR-1765): Renamed dateUnix to dateRangeUnix

c6e82b1

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/schema/nl/intensive_care_lcps.json Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/gemeente/[code]/vaccinaties.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/gemeente/[code]/vaccinaties.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/components/kpi/types.ts Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/landelijk/kwetsbare-groepen-70-plussers.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/landelijk/vaccinaties.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/landelijk/vaccinaties.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work suggested changes

View reviewed changes

Contributor

Jorrik-Klijnsma-Work left a comment

See the comments


          feat(COR-1765): PR comment resolution

b636d28

APW26 reviewed

View reviewed changes

packages/app/src/components/kpi/types.ts Outdated Show resolved Hide resolved

packages/app/src/pages/gemeente/[code]/vaccinaties.tsx Outdated Show resolved Hide resolved

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

packages/app/schema/nl/intensive_care_lcps.json Show resolved Hide resolved

packages/app/src/components/kpi/types.ts Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work reviewed

View reviewed changes

packages/app/src/components/metadata.tsx Outdated Show resolved Hide resolved


          feat(COR-1765): PR comment resolution. Solved compiler issue because …

c1a769c

…of DateRange

VWSCoronaDashboard30 commented

View reviewed changes

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

packages/app/schema/nl/intensive_care_lcps.json Show resolved Hide resolved

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved

packages/app/src/components/kpi/types.ts Outdated Show resolved Hide resolved

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

packages/app/schema/nl/hospital_lcps.json Show resolved Hide resolved

packages/app/schema/nl/intensive_care_lcps.json Show resolved Hide resolved

packages/app/src/components/metadata.tsx Outdated Show resolved Hide resolved

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved

packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx Outdated Show resolved Hide resolved

Jorrik-Klijnsma-Work previously approved these changes

View reviewed changes

Contributor

Jorrik-Klijnsma-Work left a comment

I do think the start and end unix is not the right thing to merge. But as long as there are no changes to the moment of updating or at the interval. there is no immediatee problem.

APW26 previously approved these changes

View reviewed changes


          feat(COR-1765): Schema corrections

d84824b

VWSCoronaDashboard30 dismissed APW26’s stale review via

d84824b

August 24, 2023 09:54

VWSCoronaDashboard30 dismissed Jorrik-Klijnsma-Work’s stale review via

d84824b

August 24, 2023 09:54


          feat(COR-1765): KPI values correction

fedb775

VWSCoronaDashboard30 requested review from Jorrik-Klijnsma-Work and APW26

August 24, 2023 10:18

APW26 approved these changes

View reviewed changes

VWSCoronaDashboard30 removed Hold Awaiting Data labels

Jorrik-Klijnsma-Work approved these changes

View reviewed changes

Contributor

Jorrik-Klijnsma-Work left a comment

Looks good to me!

DariaKwork approved these changes

View reviewed changes

VWSCoronaDashboard30 merged commit 56fcc70 into develop

7 checks passed

VWSCoronaDashboard30 deleted the feature/COR-1765_ZKH-in-beeld-gemiddelde-bedbezetting-per-dag branch

August 25, 2023 14:52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work approved these changes

DariaKwork DariaKwork approved these changes

APW26 APW26 approved these changes

Amber-Taal-Work Awaiting requested review from Amber-Taal-Work

ben-van-eekelen Awaiting requested review from ben-van-eekelen

VWSCoronaDashboard35 Awaiting requested review from VWSCoronaDashboard35

Labels

None yet