Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Add functionality to use archived vr_collection data #4832

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

ben-van-eekelen
Copy link
Contributor

@ben-van-eekelen ben-van-eekelen commented Aug 7, 2023

Summary

Addition of a function to create choropleth with archived VR_COLLECTION data

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


VWSCoronaDashboard29 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ben-van-eekelen ben-van-eekelen marked this pull request as ready for review August 7, 2023 13:26
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looking good!!

@ben-van-eekelen ben-van-eekelen added the dependencies Pull requests that update a dependency file label Aug 7, 2023
@ben-van-eekelen
Copy link
Contributor Author

@VWSCoronaDashboard18 Applied improvements as suggested by you.

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! good adjustments!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ben-van-eekelen ben-van-eekelen merged commit 5879a92 into develop Aug 8, 2023
7 checks passed
@ben-van-eekelen ben-van-eekelen deleted the task/add-archive-vr-collection branch August 8, 2023 07:36
@ben-van-eekelen ben-van-eekelen mentioned this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants