Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

DariaKwork
Copy link
Contributor

Summary

All the metrics with suffixes was moved from NON-Archived to the Archived folders on NL/GM levels:
Sterfte (Nl/Gm)
Vaccinaties (Nl/Gm)
Gehandicaptenzorg (Nl)
Thuiswonende-ouderen (Nl)

*No visual visible, so no screenshots are provided.

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR! it's a big one!
I do have some comments. But all of them are opinionated and nonblocking because of the working code! Please have a look

ben-van-eekelen
ben-van-eekelen previously approved these changes Aug 8, 2023
Copy link
Contributor

@ben-van-eekelen ben-van-eekelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please view comment. Approved.

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small comments. Great job on this!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the last comments are resolved you have my approval!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!!! Tomorrow we will deal with the new proto's and create a branch for the last Vr_collection left overs

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work merged commit 2055b33 into develop Aug 9, 2023
7 checks passed
@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work deleted the feature/COR-1666_moving-archived-keys-with-suffix-to-the-archived-folder branch August 9, 2023 04:18
@ben-van-eekelen ben-van-eekelen mentioned this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants