Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Feature/cor 1667 move non suffix keys to archive #4829

Merged

Conversation

ben-van-eekelen
Copy link
Contributor

@ben-van-eekelen ben-van-eekelen commented Aug 7, 2023

Summary

Archive the following keys on pages:
National

Coronamelder app

Old name of key New name
corona_melder_app_warning corona_melder_app_warning_archived_20220421
corona_melder_app_download corona_melder_app_download_archived_20220421

Besmettelijke mensen

Old name of key New name
infectious_people infectious_people_archived_20210709

Vaccinaties

Old name of key New name
repeating_shot_administered repeating_shot_administered_20220713
vaccine_coverage vaccine_coverage_archived_20220518
vaccine_delivery_per_supplier vaccine_delivery_per_supplier_archived_20211101
vaccine_stock vaccine_stock_archived_20211024
vaccine_vaccinated_or_support vaccine_vaccinated_or_support_archived_20230411

Verpleeghuiszorg

Old name of key New name
vulnerable_nursing_home vulnerable_nursing_home_archived_20230711

Municipal

Old name of key New name Comments
hospital_nice - Key isn't used anywhere (anymore) in the frontend, removed

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


VWSCoronaDashboard29 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ben-van-eekelen ben-van-eekelen marked this pull request as ready for review August 7, 2023 14:04
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff in this PR!
My last comment on the elements is something worth checking out, the others are non-blocking.

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice aligned for the sprint demo!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME! The schemas are lit! 🔥

@ben-van-eekelen ben-van-eekelen merged commit 54691ac into develop Aug 8, 2023
7 checks passed
@ben-van-eekelen ben-van-eekelen deleted the feature/COR-1667-move-non-suffix-keys-to-archive branch August 8, 2023 16:35
@ben-van-eekelen ben-van-eekelen mentioned this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants