Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feature/COR-1670-fe-refactor-validate-all-json-script #4820

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feature/COR-1670-fe-refactor-validate-all-json-script #4820

merged 1 commit into from
Jul 18, 2023

Conversation

APW26
Copy link
Contributor

@APW26 APW26 commented Jul 18, 2023

Summary

  • Cleaned up the script according to the AC
  • Tested the script against the new protos from the dev environment

@APW26 APW26 self-assigned this Jul 18, 2023
Jorrik-Klijnsma-Work
Jorrik-Klijnsma-Work approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@APW26 APW26 merged commit 1657602 into develop Jul 18, 2023
7 checks passed
@APW26 APW26 deleted the feature/COR-1670-fe-refactor-validate-all-json-script branch July 18, 2023 11:57
@VWSCoronaDashboard30 VWSCoronaDashboard30 mentioned this pull request Jul 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work approved these changes

@DariaKwork DariaKwork DariaKwork approved these changes

@Amber-Taal-Work Amber-Taal-Work Awaiting requested review from Amber-Taal-Work

@VWSCoronaDashboard30 VWSCoronaDashboard30 Awaiting requested review from VWSCoronaDashboard30

Assignees

@APW26 APW26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@APW26 @Jorrik-Klijnsma-Work @DariaKwork