feature/COR-1676-consistent-hospital-pages-labels-fix (#4943)

* feat(COR-1676): Initial solution * feat(COR-1676): Add bandpadding as parameter for hospital graphs * feat(COR-1676): Extract magic number to constant * feat(COR-1676): Changed key name to prevent move * feat(COR-1676): Set labels correctly
minvws · Dec 7, 2023 · d913e28 · d913e28
1 parent 05d19ba
commit d913e28
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx b/packages/app/src/pages/landelijk/ziekenhuizen-in-beeld.tsx
@@ -184,13 +184,13 @@ const HospitalsAndCarePage = (props: StaticProps<typeof getStaticProps>) => {
                     {
                       type: 'line',
                       metricProperty: 'beds_occupied_covid_moving_average',
-                      label: textNl.hospitals.chart_beds_occupied.legend_dot_label,
+                      label: textNl.hospitals.chart_beds_occupied.legend_trend_label,
                       color: colors.primary,
                     },
                     {
                       type: 'bar',
                       metricProperty: 'beds_occupied_covid',
-                      label: textNl.hospitals.chart_beds_occupied.legend_trend_label,
+                      label: textNl.hospitals.chart_beds_occupied.legend_dot_label,
                       color: colors.primary,
                       bandPadding: gappedBarBandPaddingOverride,
                     },
@@ -236,13 +236,13 @@ const HospitalsAndCarePage = (props: StaticProps<typeof getStaticProps>) => {
                     {
                       type: 'line',
                       metricProperty: 'beds_occupied_covid_moving_average',
-                      label: textNl.icu.chart_beds_occupied.legend_dot_label,
+                      label: textNl.icu.chart_beds_occupied.legend_trend_label,
                       color: colors.primary,
                     },
                     {
                       type: 'bar',
                       metricProperty: 'beds_occupied_covid',
-                      label: textNl.icu.chart_beds_occupied.legend_trend_label,
+                      label: textNl.icu.chart_beds_occupied.legend_dot_label,
                       color: colors.primary,
                       bandPadding: gappedBarBandPaddingOverride,
                     },
@@ -252,10 +252,11 @@ const HospitalsAndCarePage = (props: StaticProps<typeof getStaticProps>) => {
                       {
                         start: data.intensive_care_lcps.values[0].date_unix,
                         end: new Date('1 June 2020').getTime() / 1000,
-                        label: textNl.icu.chart_beds_occupied.legend_inaccurate_label,
+                        label: textNl.icu.chart_beds_occupied.legend_inaccurate_labels,
                         shortLabel: commonTexts.common.incomplete,
                       },
                     ],
+
                     timelineEvents: getTimelineEvents(content.elements.timeSeries, 'intensive_care_lcps', 'beds_occupied_covid'),
                     useDatesAsRange: false,
                   }}

diff --git a/packages/cms/src/lokalize/key-mutations.csv b/packages/cms/src/lokalize/key-mutations.csv
@@ -1 +1,3 @@
 timestamp,action,key,document_id,move_to
+2023-12-06T14:06:27.293Z,add,pages.hospitals_and_care_page.nl.icu.chart_beds_occupied.legend_inaccurate_labels,CFKdIPVDhosWzjhr2xUv19,__
+2023-12-06T14:06:27.294Z,delete,pages.hospitals_and_care_page.nl.icu.chart_beds_occupied.legend_inaccurate_label,PKXdxxxKAnTg0F1ZCrIxVz,__