PI-2536 Fix NumberFormatException attempting to parse invalid PNCs #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PNC IDs can only have up to 7 digits after the slash, but the existing regular expression allows an unlimited number. Example invalid PNC ID: 1999/9999999999a. Previously the code would try to parse 9,999,999,999 as an int, and fail.
| @@ -40,5 +40,6 @@ internal class CanonicalPncKtTest { | |||
| assertThat("SF68/945674U".canonicalPNCNumber()).isEqualTo("SF68/945674U") | |||
| assertThat("".canonicalPNCNumber()).isEqualTo("") | |||
| assertThat("2010/BBBBBBBA".canonicalPNCNumber()).isEqualTo("2010/BBBBBBBA") | |||
| assertThat("2003/012345678A".canonicalPNCNumber()).isEqualTo("2003/012345678A") | |||
There was a problem hiding this comment.
tests in this class would be a good candidate for using ParamitizedTest
There was a problem hiding this comment.
@ParameterizedTest
@CsvSource(
"2003/1234567A,2003/1234567a",
"2003/0234567A,2003/234567a"
)
internal fun will convert to canonical form of PNC when it is valid(pnc: String, expectedCrn: String) {
assertThat(pnc.canonicalPNCNumber()).isEqualTo(expectedCrn)
}
There was a problem hiding this comment.
Cheers - I've updated that to be a parameterized test. @achimber-moj could I get another review?
achimber-moj
previously approved these changes
Sep 26, 2024
achimber-moj
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNC IDs can only have up to 7 digits after the slash, but the existing regular expression allows an unlimited number.
Example invalid PNC ID: 1999/9999999999a. Previously the code would try to parse 9,999,999,999 as an int, and fail.